Skip to content

Adding a new entry about reverse proxies in the framework #4102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 8, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions book/http_cache.rst
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@ kernel::
The caching kernel will immediately act as a reverse proxy - caching responses
from your application and returning them to the client.

Now that you're using a "proxy", you'll need to configure ``127.0.0.1`` under
the ``trusted_proxies`` configuration (see :ref:`reference <reference-framework-trusted-proxies>`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"see the reference" instead of "see reference"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think my suggestion was misleading. I just wanted to have this put in parentheses. I wouldn't have changed the label. What I had in mind was this:

(see :ref:`framework.trusted_proxies <reference-framework-trusted-proxies>`)

Without this, the client's IP address and a few other things won't report correctly.

.. tip::

The cache kernel has a special ``getLog()`` method that returns a string
Expand Down Expand Up @@ -1005,8 +1009,8 @@ possible.

.. tip::

The listener only responds to local IP addresses or trusted
proxies.
The listener only responds to local IP addresses or
:doc:`trusted proxies </cookbook/request/load_balancer_reverse_proxy>`.

.. note::

Expand Down
5 changes: 5 additions & 0 deletions components/http_foundation/trusting_proxies.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
Trusting Proxies
================

.. tip::

If you're using the Symfony Framework, start by reading
:doc:`/cookbook/request/load_balancer_reverse_proxy`.

If you find yourself behind some sort of proxy - like a load balancer - then
certain header information may be sent to you using special ``X-Forwarded-*``
headers. For example, the ``Host`` HTTP header is usually used to return
Expand Down
9 changes: 9 additions & 0 deletions cookbook/cache/varnish.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ Because Symfony2's cache uses the standard HTTP cache headers, the
proxy. `Varnish`_ is a powerful, open-source, HTTP accelerator capable of serving
cached content quickly and including support for :ref:`Edge Side Includes <edge-side-includes>`.

Trusting Reverse Proxies
------------------------

For ESI to work correctly and for the :ref:`X-FORWARDED <varnish-x-forwarded-headers>`
headers to be used, you need to configure Varnish as a
:doc:`trusted proxy </cookbook/request/load_balancer_reverse_proxy>`.

.. index::
single: Varnish; configuration

Expand Down Expand Up @@ -188,6 +195,8 @@ that will invalidate the cache for a given resource:
}
}

.. _varnish-x-forwarded-headers:

Routing and X-FORWARDED Headers
-------------------------------

Expand Down
1 change: 1 addition & 0 deletions cookbook/map.rst.inc
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@

* :doc:`/cookbook/request/index`

* :doc:`/cookbook/request/load_balancer_reverse_proxy`
* :doc:`/cookbook/request/mime_type`
* (session) :doc:`/cookbook/session/locale_sticky_session`

Expand Down
1 change: 1 addition & 0 deletions cookbook/request/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ Request
.. toctree::
:maxdepth: 2

load_balancer_reverse_proxy
mime_type
103 changes: 103 additions & 0 deletions cookbook/request/load_balancer_reverse_proxy.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
How to Configure Symfony to Work behind a Load Balancer or Reverse Proxy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] or a Reverse Proxy

========================================================================

When you deploy your application, you may be behind a load balancer (e.g.
an AWS Elastic Load Balancer) or a reverse proxy (e.g. Varnish for
:doc:`caching</book/http_cache>`).

For the most part, this doesn't cause any problems with Symfony. But, when
a request passes through a proxy, certain request information is sent using
special ``X-Forwarded-*`` headers. For example, instead of reading the ``REMOTE_ADDR``
header (which will now be the IP address of your reverse proxy), the user's
true IP will be stored in an ``X-Forwarded-For`` header.

.. tip::

If you're using Symfony's :ref:`AppCache<symfony-gateway-cache>` for caching,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a space before <

then you *are* using a reverse proxy with the IP address ``127.0.0.1``.
You'll need to configure that address as a trusted proxy below.

If you don't configure Symfony to look for these headers, you'll get incorrect
information about the client's IP address, whether or not the client is connecting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the need to add this phrase here: "whether or not the client is connecting via HTTPS".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I get it now: the "whether is HTTPS or not" phrase is not related to the previous phrase about the IP address.

via HTTPS, the client's port and the hostname being requested.

Solution: trusted_proxies
-------------------------

This is no problem, but you *do* need to tell Symfony that this is happening
and which reverse proxy IP addresses will be doing this type of thing:

.. configuration-block::

.. code-block:: yaml

# app/config/config.yml
# ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standards say that there should be an empty line before this line

framework:
trusted_proxies: [192.0.0.1, 10.0.0.0/8]

.. code-block:: xml

<!-- app/config/config.xml -->
<?xml version="1.0" encoding="UTF-8" ?>
<container xmlns="http://symfony.com/schema/dic/services"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:framework="http://symfony.com/schema/dic/symfony"
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd
http://symfony.com/schema/dic/symfony http://symfony.com/schema/dic/symfony/symfony-1.0.xsd">

<framework:config trusted-proxies="192.0.0.1, 10.0.0.0/8">
<!-- ... -->
</framework>
</container>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to have the XML complete (meaning to have all elements present that sorround the framework element.

.. code-block:: php

// app/config/config.php
$container->loadFromExtension('framework', array(
'trusted_proxies' => array('192.0.0.1', '10.0.0.0/8'),
));

In this example, you're saying that your reverse proxy (or proxies) has
the IP address ``192.0.0.1`` or matches the range of IP addresses that use
the CIDR notation ``10.0.0.0/8``. For more details, see :ref:`reference-framework-trusted-proxies`.

That's it! Symfony will now look for the correct ``X-Forwarded-*`` headers
to get information like the client's IP address, host, port and whether or
not the request is using HTTPS.

But what if the IP of my Reverse Proxy Changes Constantly!
----------------------------------------------------------

Some reverse proxies (like Amazon's Elastic Load Balancers) don't have a
static IP address or even a range that you can target with the CIDR notation.
In this case, you'll need to - *very carefully* - trust *all* proxies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change all proxies by any proxy in front of your web servers here

all seems like a very strong word :)


1. Configure your web server(s) to *not* respond to traffic from *any* clients
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does using 1. repeatedly actually work? I thought it was #..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right - I'll fix that right now! I think 1. is Markdown (or I'm just crazy).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think so. I just failed with this as well. It's so intuitive, it really should have been supported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like this is not fixed, @weaverryan ? And yes, using multiple 1.'s to define an ordered list is a Markdown feature.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weaverryan fixed it in 2b1935b.

other than your load balancers. For AWS, this can be done with `security groups`_.

1. Once you've guaranteed that traffic will only come from your trusted reverse
proxies, configure Symfony to *always* trust incoming request. This is
done inside of your front controller::

// web/app.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this complete code block should be indented with 3 more spaces (3 spaces is now the new outline base in the list, and code blocks need to be indented with 4 spaces so 3 + 4 = 7 spaces, you use 4 spaces now)

// ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should be moved above the previous line

Request::setTrustedProxies(array($request->server->get('REMOTE_ADDR')));

$response = $kernel->handle($request);
// ...

That's it! It's critical that you prevent traffic from all non-trusted sources.
If you allow outside traffic, they could "spoof" their true IP address and
other information.

My Reverse Proxy Uses Non-Standard (not X-Forwarded) Headers
------------------------------------------------------------

Most reverse proxies store information on specific ``X-Forwarded-*`` headers.
But if your reverse proxy uses non-standard header names, you can configure
these (:doc:`see reference </components/http_foundation/trusting_proxies>`.
The code for doing this will need to live in your front controller (e.g. ``web/app.php``).

.. _`security groups`: http://docs.aws.amazon.com/ElasticLoadBalancing/latest/DeveloperGuide/using-elb-security-groups.html
2 changes: 1 addition & 1 deletion reference/configuration/framework.rst
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ trusted_proxies
**type**: ``array``

Configures the IP addresses that should be trusted as proxies. For more details,
see :doc:`/components/http_foundation/trusting_proxies`.
see :doc:`/cookbook/request/load_balancer_reverse_proxy`.

.. versionadded:: 2.3
CIDR notation support was introduced in Symfony 2.3, so you can whitelist whole
Expand Down