Fixes #2879 #2883
Closed
Fixes #2879 #2883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ChristopherMoll
commented
Aug 7, 2013
ChristopherMoll
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | #2879 |
|
Could you please include the pull request format in your description? Also, you should break lines after the first word that crosses the 72th character. Could you please edit this pr? |
| @@ -62,7 +62,8 @@ When you create a bundle, you have two choices on how to handle configuration: | |||
| The second option - which you'll learn about in this article - is much more | |||
| flexible, but also requires more time to setup. If you're wondering which | |||
| method you should use, it's probably a good idea to start with method #1, | |||
| and then change to #2 later if you need to. | |||
| and then change to #2 later if you need to. If you plan to distribute your | |||
There was a problem hiding this comment.
There are at least two spaces between the full stop and if.
|
Hi Christopher! Thanks for the nice change! I agree with your confusion in #2879, and this is a nice fix. The intention was so that most developers wouldn't go an add the extra overhead of using DI extensions when they're not needed. But with this change, the right choice is much clearer :). I patched your change into the 2.2 branch at sha: 9f9b390, sha: 582b2ab and sha: cd6fc62 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.