Skip to content

Replaced caution directive by warning #20448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

TimoBakx
Copy link
Member

@TimoBakx TimoBakx commented Dec 7, 2024

Fixes #20371

Both blocks are currently rendered identically. Keeping only one of the two makes it easier to contribute.

Some blocks were elevated to danger, as they describe a security risk.

#SymfonyHackday

@TimoBakx TimoBakx requested a review from xabbuh as a code owner December 7, 2024 10:58
@carsonbot carsonbot added this to the 6.4 milestone Dec 7, 2024
@OskarStark OskarStark changed the title Replaced caution blocks with warning Replaced caution directive by warning Dec 7, 2024
@OskarStark
Copy link
Contributor

Can you please also adjust the .doctor-rst.yaml file and add .. caution:: as a forbidden directive? Thanks

Fixes symfony#20371

Both blocks are currently rendered identically. Keeping only one of the two makes it easier to contribute.

Some blocks were elevated to danger.
@TimoBakx TimoBakx force-pushed the change-caution-blocks-to-warning branch from 8301aaa to 3849004 Compare December 7, 2024 11:03
@wouterj
Copy link
Member

wouterj commented Dec 7, 2024

Thanks Timo!

@wouterj wouterj merged commit fdd5743 into symfony:6.4 Dec 7, 2024
3 checks passed
@TimoBakx TimoBakx deleted the change-caution-blocks-to-warning branch December 7, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants