Remove yarn commands in front-end docs #19348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Dec 28, 2023
wouterj
approved these changes
Dec 28, 2023
|
Thank you Javier. |
|
@javiereguiluz can you please make the upmerge? Thanks |
|
@OskarStark I just upmerged everything 🙏 |
|
Thank you very much |
Closed
Kocal
added a commit
to symfony/ux
that referenced
this pull request
Oct 12, 2024
This PR was merged into the 2.x branch. Discussion ---------- Remove yarn commands in documentations | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Alternative to #1200, for the same reasons explained in symfony/symfony-docs#19348, we don't want to keep `yarn` commands. Commits ------- 88a3c73 Remove yarn commands in documentations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #19193, we discussed internally about this and we decided to remove all
yarncommands. Reasons:npmis as good and fast asyarnnpmcommands that will work becausenpmis bundled with Node.js (no need to install other package managers)npmcommands to the package manager that they use: yarn, pnpm, bun, etc.