Fix code example: replace request get() with all() method to support non-scalar types #19328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejgr
changed the title
alejgr
changed the title
xabbuh
approved these changes
Dec 24, 2023
carsonbot
changed the title
|
Thank you @alejgarciarodriguez and congratulations on your first Symfony docs contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method
$request->request->getdoes not support non-scalar types so it won't work with forms since they are received as an array type.Using
getused to work in older Symfony versions but no longer does, now an exception is thrown.IMO we should use
allmethod instead in this example.