Skip to content

Fix grammar mistake #10629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix grammar mistake #10629

wants to merge 1 commit into from

Conversation

ocrampete16
Copy link
Contributor

Just something I stumbled upon while reading through the docs.

@xabbuh xabbuh added this to the 2.8 milestone Nov 5, 2018
Copy link
Member

@zanbaldwin zanbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always been taught to use from instead of of but I'm not sure how much that depends on region/dialect of English 😕

@@ -95,7 +95,7 @@ First, to use ESI, be sure to enable it in your application configuration:

Now, suppose you have a page that is relatively static, except for a news
ticker at the bottom of the content. With ESI, you can cache the news ticker
independent of the rest of the page::
independently of the rest of the page::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
independently of the rest of the page::
independently from the rest of the page::

@@ -158,7 +158,7 @@ used ``render()``.
specification that is supported out of the box by the Symfony reverse
proxy.

The embedded action can now specify its own caching rules, entirely independent
The embedded action can now specify its own caching rules entirely independently
of the master page::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of the master page::
from the master page::

@xabbuh
Copy link
Member

xabbuh commented Nov 5, 2018

@zanbaldwin I think according to https://www.oxfordlearnersdictionaries.com/definition/english/independent_1 "independent of" is correct here.

@javiereguiluz
Copy link
Member

This proposed change is really tricky. As someone posted on Symfony's Slack, books use "independently from" more than "independently of" (see https://books.google.com/ngrams/graph?content=independently+of%2Cindependently+from&year_start=1800&year_end=2008&corpus=0&smoothing=3&share=&direct_url=t1%3B%2Cindependently%20of%3B%2Cc0%3B.t1%3B%2Cindependently%20from%3B%2Cc0).

But also, we have different opinions about this from native English speakers. Zan here leans towards "independently from" and Neal on Slack defends the use of "independently of". Both of them are native in English! So I don't know what to do :|

@zanbaldwin
Copy link
Member

Both Google Trends and Google Books seem to favour "independently of".

My suggestion of "independently from" is probably just a regional thing, so I would suggest sticking to what is most widely used ("independently of").

@ocrampete16
Copy link
Contributor Author

ocrampete16 commented Nov 5, 2018

I suppose it's a regional thing. Personally, both feel right to me (native English speaker) but I would probably lean a tad more towards independent of as well.

@javiereguiluz
Copy link
Member

This is merged now! Thanks @ocrampete16 and congrats on your first Symfony Docs contribution! Thanks also to reviewers and to our English native friends who helped us decide what to do here.

javiereguiluz added a commit that referenced this pull request Nov 6, 2018
This PR was submitted for the 3.4 branch but it was merged into the 2.8 branch instead (closes #10629).

Discussion
----------

Fix grammar mistake

Just something I stumbled upon while reading through the docs.

Commits
-------

b3566c2 Fix grammar error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants