Skip to content

"kernel.finish_request" event is missing on Symfony Framework Events #6151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Jan 15, 2016 · 3 comments
Closed

"kernel.finish_request" event is missing on Symfony Framework Events #6151

ghost opened this issue Jan 15, 2016 · 3 comments
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue.
Milestone
2.4

Comments

@ghost
Copy link

ghost commented Jan 15, 2016

The "kernel.finish_request" event is missing on this page: http://symfony.com/doc/master/reference/events.html

 ------- ---------------------------------------------------------------------------------------- ---------- 
  Order   Callable                                                                                 Priority  
 ------- ---------------------------------------------------------------------------------------- ---------- 
  #1      Symfony\Component\HttpKernel\EventListener\LocaleListener::onKernelFinishRequest()       0         
  #2      Symfony\Component\HttpKernel\EventListener\TranslatorListener::onKernelFinishRequest()   0         
  #3      Symfony\Component\HttpKernel\EventListener\RouterListener::onKernelFinishRequest()       0         
  #4      Symfony\Component\Security\Http\Firewall::onKernelFinishRequest()                        0         
 ------- ---------------------------------------------------------------------------------------- ----------

Source: $ php bin/console debug:event-dispatcher on Symfony 3.0.1.
@xabbuh xabbuh added Missing Documentation actionable Clear and specific issues ready for anyone to take them. labels Jan 15, 2016
@xabbuh xabbuh added this to the 2.4 milestone Jan 15, 2016
@xabbuh
Copy link
Member

xabbuh commented Jan 15, 2016

Indeed, good catch @JHGitty. This event was introduced in symfony/symfony#8904 and is part of Symfony since the 2.4 release. Thus, a pull request should be based on the 2.7 branch.

@ghost
Copy link
Author

ghost commented Jan 15, 2016

@xabbuh Thanks for your answer.

I don't have much time for this. Anybody can do a PR for it.

@acrobat acrobat mentioned this issue Jan 21, 2016
Merged
@acrobat
Copy link
Contributor

acrobat commented Jan 21, 2016

I've created a PR for the missing reference! See #6174

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jan 21, 2016
xabbuh added a commit that referenced this issue Jan 30, 2016
@xabbuh
feature #6174 Missing reference docs for kernel.finish_request event …
282fd8a 
…(acrobat)

This PR was merged into the 2.7 branch.

Discussion
----------

Missing reference docs for kernel.finish_request event

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | yes - missing docs (PR symfony/symfony#8904)
| Applies to    | Event was added in 2.4 so added to **2.7** docs
| Fixed tickets | #6151

Commits
-------

aad2b89 Missing reference docs for kernel.finish_request event
@xabbuh xabbuh closed this as completed Jan 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
2.4
Development

No branches or pull requests
2 participants
@acrobat @xabbuh