Skip to content

Ambiguity on Access Decision Manager's Strategy #5912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thedamnedrhino opened this issue Nov 28, 2015 · 4 comments
Closed

Ambiguity on Access Decision Manager's Strategy #5912

thedamnedrhino opened this issue Nov 28, 2015 · 4 comments
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. Security

Comments

@thedamnedrhino
Copy link

There currently two articles concerning the AcessDecisionManager's Strategy, the one from the Security Component and the One from the Cookbook. Reading the description of the _affirmative_ strategy, I noticed that these two don't match. The one from the Security Component states:

grant access as soon as any voter returns an affirmative response.

which means make the decision as soon as any voter _grants_ OR _denies_ access.
But according to the one from the cookbook:

This grants access as soon as there is one voter granting access.

Which is self explanatory but is in contradiction with the former description of this strategy.
I have found this latter description to be Correct.

@xabbuh
Copy link
Member

xabbuh commented Nov 28, 2015

Thank you for opening this issue @thedamnedrhino. Honestly, to me "any voter returns an affirmative response" sounds the same as "any voter grants access". But I would be happy to use the same sentence here as in the cookbook if that makes thinks more clear (which actually is the goal of our documentation :)).

@thedamnedrhino
Copy link
Author

You're right actually, I had an incorrect understanding of the meaning of affirmative.

@xabbuh
Copy link
Member

xabbuh commented Nov 28, 2015

Well, I think that's a reason to think about changing that sentence. There are probably more (non-native speaker) people who feel the same and if we can help understanding the docs by choosing a different wording, then imo that's the way to go.

@wouterj wouterj added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. labels Nov 28, 2015
@wouterj
Copy link
Member

wouterj commented Nov 28, 2015

Let's use "grants access" instead of "affirmative" in the cookbook (while it explains the naming of the strategy, it's not a basic-english word and we can easily work around using it)

@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label Dec 5, 2015
xabbuh added a commit that referenced this issue Dec 9, 2015
… (Pierre Maraitre)

This PR was squashed before being merged into the 2.3 branch (closes #5959).

Discussion
----------

Fix #5912 Ambiguity on Access Decision Manager's Strategy

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | >=2.3
| Fixed tickets | #5912

Commits
-------

2367e88 Fix #5912 Ambiguity on Access Decision Manager's Strategy
@xabbuh xabbuh closed this as completed Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Development

No branches or pull requests

3 participants