-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Ambiguity on Access Decision Manager's Strategy #5912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for opening this issue @thedamnedrhino. Honestly, to me "any voter returns an affirmative response" sounds the same as "any voter grants access". But I would be happy to use the same sentence here as in the cookbook if that makes thinks more clear (which actually is the goal of our documentation :)). |
You're right actually, I had an incorrect understanding of the meaning of |
Well, I think that's a reason to think about changing that sentence. There are probably more (non-native speaker) people who feel the same and if we can help understanding the docs by choosing a different wording, then imo that's the way to go. |
Let's use "grants access" instead of "affirmative" in the cookbook (while it explains the naming of the strategy, it's not a basic-english word and we can easily work around using it) |
… (Pierre Maraitre) This PR was squashed before being merged into the 2.3 branch (closes #5959). Discussion ---------- Fix #5912 Ambiguity on Access Decision Manager's Strategy | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | >=2.3 | Fixed tickets | #5912 Commits ------- 2367e88 Fix #5912 Ambiguity on Access Decision Manager's Strategy
There currently two articles concerning the AcessDecisionManager's Strategy, the one from the Security Component and the One from the Cookbook. Reading the description of the _affirmative_ strategy, I noticed that these two don't match. The one from the Security Component states:
which means make the decision as soon as any voter _grants_ OR _denies_ access.
But according to the one from the cookbook:
Which is self explanatory but is in contradiction with the former description of this strategy.
I have found this latter description to be Correct.
The text was updated successfully, but these errors were encountered: