Skip to content

Change description of the list of media types link in book/http_fundamentals #5875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
douglasnaphas opened this issue Nov 8, 2015 · 2 comments
Closed

Change description of the list of media types link in book/http_fundamentals #5875

douglasnaphas opened this issue Nov 8, 2015 · 2 comments
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required)

Comments

@douglasnaphas
Copy link

http://symfony.com/doc/current/book/http_fundamentals.html has a link to "Wikipedia's List of common media types article". The destination of the link is https://www.iana.org/assignments/media-types/media-types.xhtml. There does not appear to be a list of common media types on Wikipedia, so the text "Wikipedia's List of common media types article" should be changed to "IANA's list of common media types".
@douglasnaphas douglasnaphas changed the title Link in book/http_fundamentals to media types is wrong Change description of link in book/http_fundamentals to media types Nov 8, 2015
@douglasnaphas douglasnaphas changed the title Change description of link in book/http_fundamentals to media types Change description of the list of media types link in book/http_fundamentals Nov 8, 2015
@wouterj
Copy link
Member

wouterj commented Nov 8, 2015

I would change "A list of common media types can be found on Wikipedia's List of common media types article." to You can see a list of common media types_ on IANA. Can you maybe make the change (by clicking on the "Edit" button and changing the sentence + the reference name at the bottom of the article)?

@wouterj wouterj added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. labels Nov 8, 2015
douglasnaphas added a commit to douglasnaphas/symfony-docs that referenced this issue Nov 9, 2015
@douglasnaphas
Fixed link description, list of common media types
245e8ee 
symfony#5875
douglasnaphas pushed a commit to douglasnaphas/symfony-docs that referenced this issue Nov 29, 2015
[symfony#5875] Fixed link description, list of common media types
418e3ae
@douglasnaphas douglasnaphas mentioned this issue Nov 29, 2015
Closed
@douglasnaphas
Copy link
Author

@wouterj, that change is in the pull request above.

weaverryan pushed a commit that referenced this issue Nov 30, 2015
@weaverryan
[#5875] Fixed link description, list of common media types
5eca563
weaverryan added a commit that referenced this issue Nov 30, 2015
@weaverryan
minor #5931 [#5875] Fixed link description, list of common media type…
523d08c 
…s (Douglas Naphas)

This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5931).

Discussion
----------

[#5875] Fixed link description, list of common media types

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.7+
| Fixed tickets | #5875

Commits
-------

5eca563 [#5875] Fixed link description, list of common media types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weaverryan @wouterj @douglasnaphas