Skip to content

Wrong advice for using missing Response constants in Symfony book testing section #5770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amansilla opened this issue Oct 9, 2015 · 0 comments
Closed

Wrong advice for using missing Response constants in Symfony book testing section #5770

amansilla opened this issue Oct 9, 2015 · 0 comments
Labels
hasPR A Pull Request has already been submitted for this issue. HttpFoundation

Comments

@amansilla
Copy link

The book documentation for the version 2.3 of Symfony about testing has a confusing comment since the Symfony\Component\HttpFoundation\Response::HTTP_OK doesn't exist for 2.3 version and was introduced in 2.4. I think that comment should be removed.

I have already created a pull request to fix it.
@amansilla amansilla mentioned this issue Oct 9, 2015
Merged
@xabbuh xabbuh added HttpFoundation hasPR A Pull Request has already been submitted for this issue. labels Oct 9, 2015
xabbuh added a commit that referenced this issue Oct 9, 2015
@xabbuh
minor #5771 Remove not existing response constant (amansilla)
19e0b19 
This PR was merged into the 2.3 branch.

Discussion
----------

Remove not existing response constant

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?  | no
| Applies to    | 2.3
| Fixed tickets | #5770

Commits
-------

b38c36c Remove not existing response constant
@xabbuh xabbuh closed this as completed Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. HttpFoundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amansilla @xabbuh