Skip to content

[Session] PdoSessionHandler notice about data size #5269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tobion opened this issue May 19, 2015 · 0 comments
Closed

[Session] PdoSessionHandler notice about data size #5269

Tobion opened this issue May 19, 2015 · 0 comments
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. HttpFoundation

Comments

@Tobion
Copy link
Contributor

Tobion commented May 19, 2015

If the session data doesn't fit in the data column, it might get truncated by the RDMS (at least mysql). So the data gets corrupted and also PHP session system ignores the data without giving a warning.

So the docs should add a note for this case that people can

  • increase the column size (e.g. BLOB to MEDIUMBLOB) if they have huge session data
  • enable STRICT SQL MODE in mysql so that such an error would be noticed

Based on symfony/symfony#14647
@Tobion Tobion mentioned this issue May 19, 2015
Closed
@xabbuh xabbuh added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. HttpFoundation labels May 19, 2015
This was referenced Jul 13, 2015
Closed
Closed
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jul 14, 2015
wouterj added a commit that referenced this issue Jul 23, 2015
@wouterj
feature #5516 Added a note about session data size in PdoSessionHandl…
c9f3850 
…er (javiereguiluz)

This PR was squashed before being merged into the 2.3 branch (closes #5516).

Discussion
----------

Added a note about session data size in PdoSessionHandler

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | #5269

Commits
-------

a52b159 Added a note about session data size in PdoSessionHandler
@xabbuh xabbuh closed this as completed Jul 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. HttpFoundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tobion @xabbuh