Skip to content

Incorrect Default Session Table Name #4794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeremylivingston opened this issue Jan 8, 2015 · 0 comments
Closed

Incorrect Default Session Table Name #4794

jeremylivingston opened this issue Jan 8, 2015 · 0 comments
Labels
bug hasPR A Pull Request has already been submitted for this issue. HttpFoundation

Comments

@jeremylivingston
Copy link

The default table name in the PdoSessionHandler is "sessions" (plural).

The documentation refers to the table in numerous parts as a singular "session" table. It documents the default value as "session" when it should actually be "sessions". The schema creation scripts also use the wrong table name.

These invalid references should be updated in the docs to preserve BC in the code.

https://github.com/symfony/symfony-docs/blob/master/cookbook/configuration/pdo_session_storage.rst
@xabbuh xabbuh mentioned this issue Jan 13, 2015
Closed
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jan 13, 2015
wouterj added a commit that referenced this issue Jan 16, 2015
@wouterj
minor #4824 fix SQL: table names (e-moe)
467c538 
This PR was squashed before being merged into the 2.6 branch (closes #4824).

Discussion
----------

fix SQL: table names

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | Symfony 2.x
| Fixed tickets | #4794

Table name for sessions should be the same for all examples (see symfony config above with `sessions` table name)

Commits
-------

ecc18e2 fix SQL: table names
@wouterj wouterj closed this as completed Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug hasPR A Pull Request has already been submitted for this issue. HttpFoundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeremylivingston @wouterj @xabbuh