Skip to content

Document the "trusted_hosts" framework configuration setting #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianfp opened this issue Feb 18, 2014 · 6 comments
Closed

Document the "trusted_hosts" framework configuration setting #3586

ianfp opened this issue Feb 18, 2014 · 6 comments
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.

Comments

@ianfp
Copy link

ianfp commented Feb 18, 2014

The trusted_hosts setting was introduced here:

http://symfony.com/blog/security-releases-symfony-2-0-24-2-1-12-2-2-5-and-2-3-3-released

But is not documented here:

http://symfony.com/doc/current/reference/configuration/framework.html

@xabbuh
Copy link
Member

xabbuh commented Oct 11, 2014

see #4121

@javiereguiluz
Copy link
Member

@wouterj @xabbuh @weaverryan this issue can be safely closed because it has been solved.

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2014

@javiereguiluz Are you sure? #4121 isn't merged yet.

@weaverryan
Copy link
Member

It was actually solved in #3876 - thanks Javier!

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2014

@weaverryan #3876 was taken over by @wouterj in #4121 (which isn't merged). There are no changes in the files that are part of the 2.3 branch or any higher branch yet.

@xabbuh xabbuh reopened this Dec 12, 2014
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Dec 12, 2014
wouterj added a commit that referenced this issue May 24, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Completed framework config

This PR only changes and adds new configuration, without moving all things around. This will things a lot easier to diff and see where things have gone wrong. I'll thouroughly review this PR and merge then.

Replaces #4736

| Q | A
| --- | ---
| Doc fix? | yes
| New docs? | yes
| Applies to | 2.3+
| Fixed tickets | #4439, #3586

Commits
-------

54e8b0a Let docbot review reference
f223643 Apply some of Ryan's suggestions
7e45e8f Completed framework config reference
@wouterj
Copy link
Member

wouterj commented May 24, 2015

This is documented now.

@wouterj wouterj closed this as completed May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Development

No branches or pull requests

5 participants