-
Notifications
You must be signed in to change notification settings - Fork 100
refactor: parser #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
refactor: parser #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
commented
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! :)
I was scared that accomodating nested statements would make things more complex, but this even makes it simpler!!
crates/pgt_workspace/src/workspace/server/statement_identifier.rs
Outdated
Show resolved
Hide resolved
crates/pgt_workspace/src/workspace/server/statement_identifier.rs
Outdated
Show resolved
Hide resolved
@juleswritescode for me ParsedDocument or DocumentParse makes more sense than ParsedStatements |
juleswritescode
approved these changes
Apr 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this rewires the workspace server for better DX and adds support for sql function bodies.
closes #178
hear me out:
Document
is responsible for extracting statements from a source file. right now, this is always SQL, but in the future we could make this generic.Parser
is the new layer between the workspace server and the document. there is one parser per document, and the parser owns the document.parser.iter(ExecuteStatementMapper, CursorPositionFilter::new(pos))
and gets exactly the data it needs.