Skip to content

Add generic F401Cx pinout #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Add generic F401Cx pinout #874

merged 3 commits into from
Jan 31, 2020

Conversation

MCUdude
Copy link
Contributor

@MCUdude MCUdude commented Jan 17, 2020

This pinout is formatted the same way as the Generic F411Cx pinout and is used with the STM32F401CB/CC/CD/CE chips.

This pinout is formatted the same way as the Generic F411Cx pinout, and is used with the STM32F401CB/CC/CD/CE chips
@fpistm fpistm self-requested a review January 17, 2020 13:09
@fpistm fpistm added the new variant Add support of new bard label Jan 17, 2020
@fpistm fpistm added this to the 1.9.0 milestone Jan 17, 2020
This file doesn't really have anything to do with the 401Rx version, even though the contents are similar
@MCUdude
Copy link
Contributor Author

MCUdude commented Jan 17, 2020

Thanks for pointing this out. Should be OK now 🙂

@MCUdude
Copy link
Contributor Author

MCUdude commented Jan 17, 2020

Do you want every new pinout request to be a new PR?

At the moment I'm working on adding:

  • Generic F446Rx
  • Generic F410Rx
  • Nucleo F410RB

Is it OK if I combine the F410 pinouts into the same PR? Oh, I do have physical hardware for all the pinouts I have created (and will create). I do test it on actual hardware before submitting PRs 😉

@fpistm
Copy link
Member

fpistm commented Jan 17, 2020

This should be fine to have a PR per series.
About Generic F410Rx and Nucleo F410RB, it could be in the same PR.
The Nucleo F410RB should also use the same variant directory and then define the pin definition under switch ARDUINO_NUCLEO_F410RB.
I think about refactor some variants to point on the generic variant.

@MCUdude
Copy link
Contributor Author

MCUdude commented Jan 17, 2020

The Nucleo F410RB should also use the same variant directory and then define the pin definition under switch ARDUINO_NUCLEO_F410RB.
I think about refactor some variants to point on the generic variant.

I didn't quite understand how this would be done. I would assume you want to keep compatibility with the other 64-pin STM32F4 Nucleo boards? If so, all F4 Nucleo 64 boards would have to point to the generic pinouts.

Another thing; would it be a good idea that all "Generic F*" pinouts use the same pinout style to keep all generic pinouts as similar as possible? If so, the Generic_F103Rx would need a little work; I can do that if you want. BTW I like your approach at #851!

If the external crystal/clock has a different frequency than 8 MHz, the HSE_VALUE could simply be defined at compile time to make the F401Cx operate with a different input clock
@fpistm fpistm merged commit 95ef506 into stm32duino:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants