Skip to content

allow users to tweak the I2C timeout #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Conversation

pi-r-p
Copy link
Contributor

@pi-r-p pi-r-p commented Nov 5, 2020

Summary

This PR allow advanced users to tweak I2C timeout.

In some real time critical devices (MakAir ventilator for example), I2C reading of any device timeout after 100ms in case of bus hardware failure (short circuit between lines or bus lines to ground).

@fpistm fpistm added the enhancement New feature or request label Nov 5, 2020
@fpistm fpistm added this to the 2.0.0 milestone Nov 5, 2020
@fpistm
Copy link
Member

fpistm commented Nov 6, 2020

Hi @pi-r-p
could you fix the astyle issue.
Thanks

@pi-r-p
Copy link
Contributor Author

pi-r-p commented Nov 6, 2020

done

@fpistm fpistm self-requested a review November 6, 2020 14:26
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Note:

  • Wiki to update to reference this tweak

@fpistm fpistm merged commit bee8561 into stm32duino:master Nov 6, 2020
@fpistm
Copy link
Member

fpistm commented Nov 6, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants