Skip to content

Possible small typo in HardwareTimer.cpp? #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rmaia3d opened this issue Oct 10, 2019 · 1 comment · Fixed by #693
Closed

Possible small typo in HardwareTimer.cpp? #692

rmaia3d opened this issue Oct 10, 2019 · 1 comment · Fixed by #693
Assignees
@ABOSTM

Comments

@rmaia3d
Copy link

rmaia3d commented Oct 10, 2019

While studying the HardwareTimer.cpp code, I found a possible small typo. Around line 417, in this section

case TIMER_OUTPUT_COMPARE_ACTIVE: _channelOC[channel - 1].OCMode = TIM_OCMODE_ACTIVE; _channelIC[channel - 1].ICPolarity = TIMER_NOT_USED; break; case TIMER_OUTPUT_COMPARE_INACTIVE: _channelOC[channel - 1].OCMode = TIM_OCMODE_ACTIVE; _channelIC[channel - 1].ICPolarity = TIMER_NOT_USED; break;

Shouldn't under the timer inactive case, the following line read?

_channelOC[channel - 1].OCMode = TIM_OCMODE_INACTIVE;
@ABOSTM
Copy link
Contributor

ABOSTM commented Oct 10, 2019

Hi @rmaia3d,
You are right, thanks for reporting.
I will fix it soon.

ABOSTM added a commit to ABOSTM/Arduino_Core_STM32 that referenced this issue Oct 11, 2019
@ABOSTM
Set TIM_OCMODE_INACTIVE when mode TIMER_OUTPUT_COMPARE_INACTIVE is se…
a29be9b 
…lected

Fixes stm32duino#692
@ABOSTM ABOSTM mentioned this issue Oct 11, 2019
Merged
fpistm pushed a commit that referenced this issue Oct 11, 2019
@ABOSTM @fpistm
Set TIM_OCMODE_INACTIVE when mode TIMER_OUTPUT_COMPARE_INACTIVE is se…
391e313 
…lected

Fixes #692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ABOSTM ABOSTM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set TIM_OCMODE_INACTIVE when using mode TIMER_OUTPUT_COMPARE_INACTIVE ABOSTM/Arduino_Core_STM32
2 participants
@rmaia3d @ABOSTM