Skip to content

Add C implementation for @stdlib/math/base/special/ellipk #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 14, 2023
Merged

Add C implementation for @stdlib/math/base/special/ellipk #769

merged 15 commits into from
Feb 14, 2023

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Dec 24, 2022 •
edited
Loading

Resolves #766.

Checklist

  • update readme.md
  • include.gypi
  • binding.gyp
  • include/stdlib/math/base/special/
  • evalpoly.js
  • src
  • manifest.json
  • lib
  • examples
  • benchmark
  • test

@kgryte

@Pranavchiku
Copy link
Member Author

All tests and benchmarks cleared, this PR can have a final review.

@Pranavchiku Pranavchiku marked this pull request as ready for review December 24, 2022 05:47
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Feb 14, 2023
kgryte
kgryte approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Pranavchiku!

@kgryte kgryte merged commit e8a382b into stdlib-js:develop Feb 14, 2023
@yaswanthkosuru yaswanthkosuru mentioned this pull request Feb 26, 2024
Closed
3 tasks
@Pranavchiku Pranavchiku mentioned this pull request Mar 2, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/ellipk
2 participants
@Pranavchiku @kgryte