Skip to content

Fix: implement circularBuffer type checks #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix: implement circularBuffer type checks #480

wants to merge 3 commits into from

Conversation

mohamadaminkarami
Copy link

Resolves #474 .

Description

What is the purpose of this pull request?

This pull request:

  • cover the entire API surface of CircularBuffer to ensure that the current definitions are correct.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@kgryte
Copy link
Member

kgryte commented Feb 4, 2022

Thanks, @mohamadaminkarami, for your interest in contributing to stdlib. I looked over the PR and some updates need to be made.

For clarity, this PR, as it currently stands, does not full address #474. The entire API surface includes various prototype methods which would need to be tested in order for that issue to be closed. See circular-buffer.

@kgryte
Copy link
Member

kgryte commented Feb 16, 2022

@mohamadaminkarami Would you mind checking the box in the OP, indicating that you've read the contributing guidelines? This is necessary for licensing and the project's ability to use code that you contribute.

@kgryte kgryte added Documentation Improvements, additions, or changes to documentation. TypeScript Issue involves or relates to TypeScript. labels Feb 16, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements, additions, or changes to documentation. TypeScript Issue involves or relates to TypeScript.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insufficient TypeScript declaration tests for @stdlib/utils/circular-buffer
2 participants