Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dmediansorted #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 2, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dmediansorted #4466

merged 6 commits into from
Jan 2, 2025

Conversation

aayush0325
Copy link
Member

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dmediansorted
  • refactors JavaScript implementation
  • updates tests, docs, benchmarks and examples

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aayush0325
feat: add C ndarray interface and refactor implementation
f4976f9 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 2, 2025
@aayush0325
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2025
@aayush0325
Copy link
Member Author

aayush0325 commented Jan 2, 2025 •
edited
Loading

do we need to update the C implementation to use math/base/special/floor like in the JavaScript implementation?? the current one seems to work just fine so i haven't changed it. it came over my mind so confirming here

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 2, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dmediansorted $\color{green}307/307$
$\color{green}+100.00\%$ 		$\color{green}14/14$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}307/307$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Jan 2, 2025

do we need to update the C implementation to use math/base/special/floor like in the JavaScript implementation??

No, as N has an integer dtype in C and we can use bitwise operators. We use floor in JS, as bitwise operators are only defined for int32, and N can exceed the max int32.

@kgryte
docs: fix grammar
aa871a1 
Signed-off-by: Athan <[email protected]>
@kgryte
docs: fix grammar
598d65e 
Signed-off-by: Athan <[email protected]>
@aayush0325
Copy link
Member Author

do we need to update the C implementation to use math/base/special/floor like in the JavaScript implementation??

No, as N has an integer dtype in C and we can use bitwise operators. We use floor in JS, as bitwise operators are only defined for int32, and N can exceed the max int32.

exactly my reasoning for not changing it

kgryte
kgryte approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit b9c545d into stdlib-js:develop Jan 2, 2025
13 checks passed
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jan 2, 2025
@aayush0325 aayush0325 deleted the ndarray-dmediansorted branch January 2, 2025 20:23
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 3, 2025
@aayush0325 @kgryte
@stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
605cc35 
…base/dmediansorted`

PR-URL: stdlib-js#4466
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
@aayush0325 @kgryte
@stdlib-bot @0PrashantYadav0
feat: add C ndarray interface and refactor implementation for `stats/…
e51f2ef 
…base/dmediansorted`

PR-URL: stdlib-js#4466
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@aayush0325 @kgryte
@stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
42e01c7 
…base/dmediansorted`

PR-URL: stdlib-js#4466
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Feb 23, 2025
@aayush0325 @kgryte
@stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
0ac69f7 
…base/dmediansorted`

PR-URL: stdlib-js#4466
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@aayush0325 @kgryte
@stdlib-bot @ShabiShett07
feat: add C ndarray interface and refactor implementation for `stats/…
7fd1722 
…base/dmediansorted`

PR-URL: stdlib-js#4466
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aayush0325 @stdlib-bot @kgryte