-
-
Notifications
You must be signed in to change notification settings - Fork 823
feat: add C ndarray
interface and refactor implementation for stats/base/dnanmeanwd
#4251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Neeraj Pathak <[email protected]>
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/stats/base/dnanmeanwd/benchmark/benchmark.native.js
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dnanmeanwd/benchmark/benchmark.ndarray.js
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dnanmeanwd/benchmark/benchmark.ndarray.native.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is shaping up. Just a few small comments. When addressed, this PR should be ready for merge.
@Neerajpathak07 You'll want to check whether any of the requested changes apply to your other similar PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for working on this, @Neerajpathak07.
…s/base/dnanmeanwd` PR-URL: stdlib-js#4251 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
…s/base/dnanmeanwd` PR-URL: stdlib-js#4251 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
…s/base/dnanmeanwd` PR-URL: stdlib-js#4251 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
…s/base/dnanmeanwd` PR-URL: stdlib-js#4251 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
…s/base/dnanmeanwd` PR-URL: stdlib-js#4251 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
Resolves none
Description
This pull request:
ndarray
interface forstats/base/dnanmeanwd
manifest.json
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers