Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dnanmeanwd #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 3, 2025

Conversation

Neerajpathak07
Copy link
Member

@Neerajpathak07 Neerajpathak07 commented Dec 26, 2024

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dnanmeanwd
  • refactor JavaScript implementation
  • refactor examples, tests, docs and benchmarks in manifest.json

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 26, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 26, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dnanmeanwd $\color{green}402/402$
$\color{green}+100.00\%$
$\color{green}23/23$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}402/402$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 26, 2024 09:01
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 26, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 31, 2024
Signed-off-by: Athan <[email protected]>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is shaping up. Just a few small comments. When addressed, this PR should be ready for merge.

@Neerajpathak07 You'll want to check whether any of the requested changes apply to your other similar PRs.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this, @Neerajpathak07.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Changes Pull request which needs changes before being merged. labels Jan 3, 2025
@kgryte kgryte merged commit 2832442 into stdlib-js:develop Jan 3, 2025
28 checks passed
@Neerajpathak07 Neerajpathak07 deleted the ndarray-dnanmeanwd branch January 3, 2025 09:40
Neerajpathak07 added a commit to Neerajpathak07/stdlib that referenced this pull request Jan 3, 2025
…s/base/dnanmeanwd`

PR-URL: stdlib-js#4251
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
…s/base/dnanmeanwd`

PR-URL: stdlib-js#4251
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Neerajpathak07 added a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
…s/base/dnanmeanwd`

PR-URL: stdlib-js#4251
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Neerajpathak07 added a commit to Neerajpathak07/stdlib that referenced this pull request Feb 23, 2025
…s/base/dnanmeanwd`

PR-URL: stdlib-js#4251
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
…s/base/dnanmeanwd`

PR-URL: stdlib-js#4251
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants