Skip to content

feat: add C implementation for stats/base/dists/bernoulli/entropy #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 28, 2024

Conversation

vivekmaurya001
Copy link
Contributor

@vivekmaurya001 vivekmaurya001 commented Dec 11, 2024

Resolves #3412.

Description

  • adds C implementation for @stdlib/stats/base/dists/bernoulli/entropy along with relevant tests, benchmarks and examples

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 11, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 11, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/bernoulli/entropy $\color{green}178/178$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}178/178$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivekmaurya001 Before opening many simultaneous PRs, please prioritize improving your existing PRs. Many of the mistakes flagged in this PR will need to be corrected across your other PRs. You'll save yourself (and us!) work and time by getting things right the first time.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 11, 2024
@vivekmaurya001
Copy link
Contributor Author

@kgryte , I understand my mistake , I am correcting it

@vivekmaurya001
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 11, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 11, 2024
@vivekmaurya001
Copy link
Contributor Author

@kgryte , changes done please give a look !

@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/stats/base/dists/bernoulli/entropy feat: add C implementation for stats/base/dists/bernoulli/entropy Dec 15, 2024
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 15, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this one finally in...

]
}
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 28, 2024
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Dec 28, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 28, 2024

PR Commit Message

feat: add C implementation for `stats/base/dists/bernoulli/entropy`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3449
Closes: https://github.com/stdlib-js/stdlib/issues/3412

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 08c0de6 into stdlib-js:develop Dec 28, 2024
27 checks passed
@vivekmaurya001 vivekmaurya001 deleted the bernoulli/entropy branch January 1, 2025 05:01
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 1, 2025
PR-URL: stdlib-js#3449
Closes: stdlib-js#3412

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
PR-URL: stdlib-js#3449
Closes: stdlib-js#3412

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#3449
Closes: stdlib-js#3412

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/bernoulli/entropy
4 participants