feat: add C implementation for math/base/special/ahaversin
#1724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planeshifter
changed the title
math/base/special/ahaversin
Pranavchiku
suggested changes
Mar 6, 2024
lib/node_modules/@stdlib/math/base/special/ahaversin/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/ahaversin/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/ahaversin/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/ahaversin/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/ahaversin/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/ahaversin/manifest.json
Outdated
Show resolved
Hide resolved
Pranavchiku
added
Feature
Signed-off-by: Rejoan Sardar <[email protected]>
Signed-off-by: Rejoan Sardar <[email protected]>
Signed-off-by: Rejoan Sardar <[email protected]>
|
@Pranavchiku I have addressed all the issues you mentioned in your review. Please take a look at the changes |
lib/node_modules/@stdlib/math/base/special/ahaversin/src/main.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
approved these changes
Mar 10, 2024
Great, thanks for that. |
@Planeshifter sir u approved these changes and said that LGTM. Much appreciated but not merged this PR.Sir any changes need from my side. |
|
@Rejoan-Sardar Looks like CI is failing and I didn't find the time to properly debug. I think there is a problem running benchmarks and examples. |
| LIBPATH ?= | ||
|
|
||
| # List of C targets: | ||
| c_targets := benchmark.out |
There was a problem hiding this comment.
Suggested change
| c_targets := benchmark.out | |
| c_targets := example.out |
Signed-off-by: Rejoan Sardar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1420 .
Description
This pull request:Add C implementation for @stdlib/math/base/special/ahaversin
Related Issues
This pull request:
@stdlib/math/base/special/ahaversin#1420Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers