Skip to content

test: add missing tests to utils/circular-buffer #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2024
Merged

test: add missing tests to utils/circular-buffer #1403

merged 3 commits into from
Sep 7, 2024

Conversation

skoriop
Copy link
Contributor

@skoriop skoriop commented Feb 28, 2024 •
edited by kgryte
Loading

Toward #474.

Description

What is the purpose of this pull request?

This pull request adds missing tests to utils/circular-buffer.

Related Issues

Does this pull request have any related issues?

This pull request progresses #474.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@skoriop
Copy link
Contributor Author

skoriop commented Mar 2, 2024

Hi, is there something blocking this?

@Planeshifter
Copy link
Member

@skoriop Your changes look good and can be merged, but the linked issue includes adding tests for the remaining API surface area of the CircularBuffer class. Would you be able to add further tests for its methods? That would be much appreciated!

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Mar 17, 2024
@kgryte
Copy link
Member

kgryte commented Mar 17, 2024

As is, these changes do not satisfy #474.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. TypeScript Issue involves or relates to TypeScript. labels Mar 17, 2024
Planeshifter and others added 2 commits September 7, 2024 13:42
@Planeshifter @kgryte
chore: update comment
bbee282 
Co-authored-by: Athan <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
chore: collapse tests
4da03d8 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter merged commit 8edb71d into stdlib-js:develop Sep 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

Assignees
No one assigned
Labels
Needs Changes Pull request which needs changes before being merged. Tests Pull requests specifically adding tests. TypeScript Issue involves or relates to TypeScript.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skoriop @Planeshifter @kgryte