Skip to content

[RFC]: Add C implementation for @stdlib/math/base/special/pow #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Pranavchiku opened this issue Mar 3, 2024 · 8 comments · Fixed by #1739
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/pow #1656

Pranavchiku opened this issue Mar 3, 2024 · 8 comments · Fixed by #1739
Assignees
@aman-095
Labels
C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@Pranavchiku
Copy link
Member

Description

This RFC proposes adding native C implementation for @stdlib/math/base/special/pow.

double stdlib_base_pow( const double b, const double x )

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Pranavchiku Pranavchiku added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. difficulty: 3 Likely to be challenging but manageable. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. C Issue involves or relates to C. labels Mar 3, 2024
@Pranavchiku
Copy link
Member Author

Implementing this will unblock a lot of packages, but it will take some time and is on a difficult side. Requesting new comers to avoid unless they have added C implementation for atleast 5 math functions ( feel confident enough ).

@Pratik772846
Copy link
Contributor

@Pranavchiku I would like to work on this issue.

@aman-095
Copy link
Member

aman-095 commented Mar 3, 2024

Hey, @Pranavchiku I have added C implementations for a few math functions, and I have a fair understanding of the code flow. I would like to contribute to this issue. 

@Pranavchiku
Copy link
Member Author

@Pratik772846 you may feel free to pick over any of easy math packages, this will be tricky for you at moment. I'll let @aman-095 give a shot to this.

@aman-095
Copy link
Member

aman-095 commented Mar 3, 2024

I have implementation ready for this, but it requires C implementation of is-even and is-odd functions. Should I go ahead and implement these two as well?

@Pranavchiku
Copy link
Member Author

Ahh, I might have missed out checking those, it will be fairly simple, proceed and get those done.

@Pranavchiku Pranavchiku mentioned this issue Mar 3, 2024
Closed
3 tasks
@aman-095 aman-095 mentioned this issue Mar 6, 2024
Merged
1 task
@gunjjoshi
Copy link
Member

Hey @aman-095, are you still working on this ?

@aman-095
Copy link
Member

Yes @gunjjoshi , I am working on this.

Planeshifter added a commit that referenced this issue Jun 19, 2024
@aman-095 @kgryte @Planeshifter
feat: add C implementation for math/base/special/pow
4a0235a 
PR-URL: #1739
Closes: #1656

---------

Signed-off-by: Athan <[email protected]>
Co-authored-by: Athan <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aman-095 aman-095

Labels
C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add C implementation for math/base/special/pow aman-095/stdlib
4 participants
@gunjjoshi @Pranavchiku @aman-095 @Pratik772846