Skip to content

Add a New Check For Annotations on PersistentVolumeClaims #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

hanife-Orthopy
Copy link

@hanife-Orthopy hanife-Orthopy commented Mar 11, 2025

Added

  • A new check for annotations on PVCs or volumeClaimTemplates in StatefulSets.

This PR is related to #815

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 80.26316% with 15 lines in your changes missing coverage. Please review.

Project coverage is 29.73%. Comparing base (a100d89) to head (386d67d).
Report is 114 commits behind head on main.

Files with missing lines Patch % Lines
pkg/extract/sts_spec.go 81.81% 3 Missing and 1 partial ⚠️
pkg/objectkinds/pvc.go 50.00% 2 Missing and 1 partial ⚠️
...volumeclaimtemplates/internal/params/gen-params.go 86.36% 2 Missing and 1 partial ⚠️
pkg/templates/volumeclaimtemplates/template.go 87.50% 2 Missing and 1 partial ⚠️
pkg/lintcontext/mocks/context.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #922       +/-   ##
===========================================
- Coverage   62.36%   29.73%   -32.63%     
===========================================
  Files         197      205        +8     
  Lines        4854     5908     +1054     
===========================================
- Hits         3027     1757     -1270     
- Misses       1439     4018     +2579     
+ Partials      388      133      -255     
Flag Coverage Δ
unit 29.73% <80.26%> (-32.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant