some more build updates #319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brody4hire
commented
Jan 9, 2020
brody4hire
force-pushed
the
more-build-updates
branch
from
7bfbf0d to
868632d
Compare
|
I just updated this proposal to remove the change I proposed in ea45e77, remove an extra blank line, and rename the proposed build target to |
|
I am splitting this one up. P.S. I am holding off on the proposed |
This was referenced Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most important:
less important - updated:
simplify wrapping of dist/*.jsdist/sql-asm-memory-growth-debug.jsbuild targetThe proposed
dist/sql-asm-memory-growth-debug.jsbuild target would also help me support a custom build for a major customer. I will completely understand if this proposed build target is not wanted.I would also be happy to split some of these changes out if needed.