Skip to content

refactor: Complete refactor #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 37 commits into from
Closed

refactor: Complete refactor #290

wants to merge 37 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 17, 2019

No description provided.

pwnsdx added 30 commits May 22, 2019 01:46
Use sqleet as database engine
12752f3
Add current build to the demo GUI
7737a46
Delete demo redirect
89b7b6b
Added PRAGMA key to the demo GUI
8f1b488
Update index.html
bb52d24
Update README.md
2c62372
Typo
b2db1c7
Update docs
439804a
Typo
4350835
Bugfixes
0fdaa48
sort exported functions
f1cd464
export key/rekey functions from sqleet
69ad8a8
Typo
e7776b1
Added sqlite3_key/sqlite3_rekey in exports.coffee
8914541
Added sqlite3_key/sqlite3_rekey support in the api
8794c3b
Typo
8e9c8ff
First version with encryption support
21ca159
Added encryption in readme code snippet
baf6536
Fixed missing sqlite3_reset
dc7b815
New builds
a078bab
Merge branch 'pr/2'
8075c8e
Update sqleet version
4422bd2
Update checksum
fa8bdea
sqleet.js update
271716b
Added support for IndexedDB saving
d67a0d1
Update dist
05a96f6
Release
591407f
Typo
ed38a12
Rename simple.html to demo.html
7ae1d9d
Typescript conversion, removed worker
80a3ee8
pwnsdx added 7 commits August 14, 2019 16:31
Small improvements
8935c62
Minor improvements
7953bc5
Improvements
56b07d9
Update demo.html
f904fa8
Prototype using Web Worker
1e904fa
Typos
dcbea54
Huge refactor to use Shared Workers 🎉
bd3946f 
- Also refactored getAsObject()
- Added a queuing system for the Proxy
- Added the ability to proxy statements calls from prepare()
@ghost ghost closed this Aug 17, 2019
@ghost
Copy link
Author

ghost commented Aug 17, 2019

My bad, sorry!

@lovasoa
Copy link
Member

lovasoa commented Aug 18, 2019

wow, it looks like you did a lot of nice work there! Why did you close the PR?

@ghost
Copy link
Author

ghost commented Aug 18, 2019

Hello, thank you for the comment! There is a a few differences that made me do a fork instead of a PR:

  • The fork uses Shared Worker which is not working on Safari, something you might want to keep (there might be a workaround by using Service Worker but the fact that they can be killed while the page is still there can be an issue), Web Workers will cause issue as they cannot communicate between each others and therefore opening multiple instances of the db (multiple tabs for example) will most likely create weird bugs, at worst corrupt the database.
  • I removed each and createFunction, which is not possible in an Shared Worker environment as you cannot pass functions when using postMessage (also I'm not using any of the two so that was easy to fix)
  • I removed ASM support, which you seems to keep
  • And to finish, I moved all the Coffeescript code to Typescript

If you are still interested in merging it in your main branch feel free to reach me at @pwnsdx on Twitter or Wire

Regards,
Sabri

@lovasoa lovasoa mentioned this pull request Feb 24, 2020
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lovasoa