Migrate QuerydslDataFetcher to use fluent Querydsl API #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove supporting classes for external projection as projections are handled by Spring Data directly.
We now request only property paths from the repository query that are requested through a GraphQL query if the result type is not a projection. That reduces the amount of data being retrieved from the underlying data store.
|
I haven't found an easy way to test |
rstoyanchev
added
in: data
rstoyanchev
pushed a commit
that referenced
this pull request
Oct 27, 2021
Remove supporting classes for external projection as projections are handled by Spring Data directly. See gh-168
rstoyanchev
pushed a commit
that referenced
this pull request
Oct 27, 2021
We now request only property paths from the repository query that are requested through a GraphQL query if the result type is not a projection. That reduces the amount of data being retrieved from the underlying data store. See gh-168
|
Reopening as this broke the build. |
|
My bad - initially I could consistently reproduce the issue and now everything works, CI is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove supporting classes for external projection as projections are handled by Spring Data directly.
Limit field projection according to field selection.
Closes gh-87