Do not convert from LocalDateTime to Timestamp by default. #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most supported databases don't need that conversion. Db2 does need it and gets it through JdbcDb2Dialect. As part of the effort it became obvious that the filtering for conversions between Date and JSR310 data types was broken. It is fixed now, which required a dedicated reading conversion from LocalDateTime to Date for JdbcMySqlDialect. Closes #974
mp911de
requested changes
Jun 8, 2021
| private static final StoreConversions STORE_CONVERSIONS = StoreConversions.of(JdbcSimpleTypes.HOLDER, | ||
| STORE_CONVERTERS); | ||
|
|
||
| private static final Predicate<ConvertiblePair> excludeConversionsBetweenDateAndJsr310Types= cp -> !isDateTimeApiConversion(cp); |
There was a problem hiding this comment.
Could we rewrite this into a method-reference form?
| * | ||
| * @since 2.3 | ||
| */ | ||
| public JdbcCustomConversions(StoreConversions storeConversions, List<?> userConverters) { | ||
| super(new ConverterConfiguration(storeConversions, userConverters, JdbcCustomConversions::isDateTimeApiConversion)); | ||
| super(new ConverterConfiguration(storeConversions, userConverters, cp -> !isDateTimeApiConversion(cp))); |
There was a problem hiding this comment.
should this reuse excludeConversionsBetweenDateAndJsr310Types?
| JdbcCustomConversions customConversions = new JdbcCustomConversions( | ||
| (List<?>) new JdbcMySqlDialect().getConverters()); | ||
|
|
||
| SoftAssertions.assertSoftly(softly -> { |
There was a problem hiding this comment.
Let's stick to static imports for AssertJ.
Use static import for `SoftAssertions.assertSoftly` everywhere. Polishing of the conversion filter. See #974
mp911de
pushed a commit
that referenced
this pull request
Jun 10, 2021
Most supported databases don't need that conversion. Db2 does need it and gets it through JdbcDb2Dialect. As part of the effort it became obvious that the filtering for conversions between Date and JSR310 data types was broken. It is fixed now, which required a dedicated reading conversion from LocalDateTime to Date for JdbcMySqlDialect. Closes #974 Original pull request: #985.
|
That's merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most supported databases don't need that conversion.
Db2 does need it and gets it through
JdbcDb2Dialect.As part of the effort it became obvious that the filtering for conversions between
Dateand JSR310 data types was broken.It is fixed now, which required a dedicated reading conversion from
LocalDateTimetoDateforJdbcMySqlDialect.Closes #974
Please review the part about filtering conversions especially carefully. After looking at the git history for some time I was rather confused.