Skip to content

fix bug: IndexQuery's id get ignored in bulkIndexOperation #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

scoobyzhang
Copy link
Contributor

@scoobyzhang scoobyzhang commented Dec 26, 2022

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our [issue tracker](https://github.
    com/spring-projects/spring-data-elasticsearch/issues)
    . Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #2405

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 26, 2022
@sothawo sothawo added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 27, 2022
Copy link
Collaborator

@sothawo sothawo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding and fixing this.

Can you please add tests to the org.springframework.data.elasticsearch.core.ElasticsearchIntegrationTests class that verify the fixed behaviour (and prove the wrong behaviour before the change)?

@scoobyzhang
Copy link
Contributor Author

@sothawo Thanks for your reply. I've pushed another commit with the test, please check it.

@sothawo sothawo merged commit 4d7d095 into spring-projects:main Dec 27, 2022
sothawo pushed a commit that referenced this pull request Dec 27, 2022
Original Pull Request #2407
Closdes #2405

(cherry picked from commit 4d7d095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexQuery's id is ignored in elasticsearchTemplate.bulkIndex
3 participants