Skip to content

Add suppport for SearchTemplateRequests #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sothawo opened this issue Aug 2, 2021 · 3 comments · Fixed by #1894 or #2410
Closed

Add suppport for SearchTemplateRequests #1891

sothawo opened this issue Aug 2, 2021 · 3 comments · Fixed by #1894 or #2410
Assignees
@sothawo
Labels
in: core Issues in core support type: enhancement A general enhancement
Milestone
5.1 M1 (2023.0.0)

Comments

@sothawo
Copy link
Collaborator

sothawo commented Aug 2, 2021 •
edited
Loading

Follow-up to #1725, there was a SearchTemplateRequestBuilder added to the NativeSearchQuery, but that is not the right place.

We need to define the parameters for a search template request and add a search(template) method to the different SearchOperations interfaces and implement them (#1725 only added the support the the ReactiveElasticsearchClient, not to the operations).

Note: update the answer in https://stackoverflow.com/questions/68572136/how-to-use-elastic-search-template-idstored-in-es-cluster-in-spring-boot-get-r when this is implemented
@sothawo sothawo added the type: enhancement A general enhancement label Aug 2, 2021
@sothawo sothawo added this to the 4.3 M2 (2021.1.0) milestone Aug 2, 2021
@sothawo sothawo self-assigned this Aug 2, 2021
sothawo added a commit to sothawo/spring-data-elasticsearch that referenced this issue Aug 2, 2021
@sothawo
Add suppport for SearchTemplateRequest to NativeSearchQuery.
e3d1d6f 
Closes spring-projects#1891
@sothawo sothawo changed the title Add suppport for SearchTemplateRequest to NativeSearchQuery Add suppport for SearchTemplateRequests Aug 2, 2021
@sothawo sothawo removed their assignment Aug 3, 2021
@sothawo sothawo mentioned this issue Aug 6, 2021
Merged
@sothawo
Copy link
Collaborator Author

sothawo commented Aug 6, 2021

falsely linked from PR #1894

@sothawo sothawo reopened this Aug 6, 2021
@sothawo sothawo added the in: core Issues in core support label Aug 27, 2021
@sothawo sothawo removed this from the 4.3 M2 (2021.1.0) milestone Aug 27, 2021
@imchao9
Copy link

imchao9 commented Oct 29, 2021 •
edited
Loading

Has this finished now?
Hope can use this feature ASAP
If have some problem, I can help.

@sothawo
Copy link
Collaborator Author

sothawo commented Oct 29, 2021

This is still an open issue.

@sothawo sothawo self-assigned this Dec 19, 2022
@sothawo sothawo added the status: worked on a contributor is working on this issue label Dec 19, 2022
@sothawo sothawo mentioned this issue Dec 30, 2022
Merged
sothawo added a commit that referenced this issue Dec 30, 2022
@sothawo
Implement search by template.
efd3943 
Original Pull Request #2410
Closes #1891
@sothawo sothawo removed the status: worked on a contributor is working on this issue label Dec 30, 2022
@sothawo sothawo added this to the 5.1 M1 (2022.1.0) milestone Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sothawo sothawo

Labels
in: core Issues in core support type: enhancement A general enhancement
Projects
None yet
Milestone
5.1 M1 (2023.0.0)
2 participants
@imchao9 @sothawo