我花了很久的时间来跟踪这个问题，希望这段代码能使我的自定义的Environment正常工作 #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello John, thanks for your contribution :) Would you mind to explain what you did and why - in plain english ;-) Cheers, |
|
I think I got what he's shooting for and filed DATACMNS-492. More sophisticated implementation coming, but thanks for the submission and making us aware of the issue! |
odrotbohm
added a commit
that referenced
this pull request
Apr 29, 2014
…ment. Added a constructor to RepositoryConfigurationDelegate that takes an additional Environment instance to make sure we can equip ClasspathScanningCandidateComponentProviders with Environments to make sure they only find components matching the environment. Retain the old constructor by defaulting to the Environment the ResourceLoader potentially contains or even a StandardEnvironment in worse cases. This is primarily to not break existing clients. Those should be upgraded to use the new constructor, of course. Needed to add an additional guard in BeanDefinitionRegistrarSupport as Spring 3.2.8 fails to invoke EnvironmentAware (filed SPR-11744 for that). This should be removed once we upgrade to Spring 3.2.9. Related pull request: #80. Related tickets: DATACMNS-493, DATACMNS-494, SPR-11744.
|
You got me!Thank you Oliver! You are great! |
odrotbohm
added a commit
that referenced
this pull request
Apr 29, 2014
…ment. Added a constructor to RepositoryConfigurationDelegate that takes an additional Environment instance to make sure we can equip ClasspathScanningCandidateComponentProviders with Environments to make sure they only find components matching the environment. Retain the old constructor by defaulting to the Environment the ResourceLoader potentially contains or even a StandardEnvironment in worse cases. This is primarily to not break existing clients. Those should be upgraded to use the new constructor, of course. Needed to add an additional guard in BeanDefinitionRegistrarSupport as Spring 3.2.8 fails to invoke EnvironmentAware (filed SPR-11744 for that). This should be removed once we upgrade to Spring 3.2.9. Related pull request: #80. Related tickets: DATACMNS-493, DATACMNS-494, SPR-11744.
thomasdarimont
pushed a commit
to thomasdarimont/spring-data-commons
that referenced
this pull request
Jul 1, 2015
We now delegate calls to invokeFindOne to the correct target repository. Original pull request: spring-projects#80.
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
If user has @EnableDiscoveryClient but no implementation (e.g. if he just has @EnableZuulProxy) the autoconfig will now kick in and provide an instance of NoopDiscoveryClient. Fixes spring-projectsgh-80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
我正在我的项目中尝试spring-data-jpa，然后发现了这个问题，希望这段代码有用，谢谢！