Added a exception handling for when was specified the invalid value in the pagination parameter. #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServletRequestBindingException an IllegalArgumentException.
|
I think that may be another solution. |
|
Would you mind creating a ticket in JIRA for this? |
|
created a ticket in JIRA. |
odrotbohm
added a commit
that referenced
this pull request
Dec 5, 2013
…fully. The PageableHandlerMethodArgumentResolver and SortHandlerMethodArgumentResolver now transparently ignore invalid values provided for page number, size and sort. We fall back to ignore the invalid values (for sort) and fall back to the defaults where appropriate (page number and size). Used and adapted test cases from pull request #48.
odrotbohm
added a commit
that referenced
this pull request
Dec 5, 2013
…fully. The PageableHandlerMethodArgumentResolver and SortHandlerMethodArgumentResolver now transparently ignore invalid values provided for page number, size and sort. We fall back to ignore the invalid values (for sort) and fall back to the defaults where appropriate (page number and size). Used and adapted test cases from pull request #48.
|
thanks that this issue resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[example of invalid value]
Current implementation of the PageableHandlerMethodArgumentResolver is occurred IllegalArgumentException, and http response status is returned 500(Innternal Server Error) on the default setting of SpringMVC.
I think a best that http response status is returned 400(Bad Request).
Easy a way for resolve this problem is that catch a IllegalArgumentException in PageableHandlerMethodArgumentResolver, and throw a ServletRequestBindingException.
ServletRequestBindingException is handled by the DefaultHandlerExceptionResolver, and http response status is returned 400(Bad Request).
What Do you think?
If you have a same thinking, Please pushed to a master branch.