Register reflection hints for Querydsl Q types. #2743
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduced support for registering GraalVM native reflection type hints for Querydsl Q types that target domain types used in the repository interface declaration. At this point we only do a simple lookup for Q types based in the very same package that implement EntityPath. More advanced configuration (eg. base package and type prefix), potentially available via EntityPathResolver are not taken into account as this would require eager bean resolution from the application context, which is likely to trigger additional infrastructure. In this case the user is required to register Q types manually.
mp911de
reviewed
Dec 9, 2022
| private final static Log logger = LogFactory.getLog(QTypeContributor.class); | ||
| private static Function<ClassLoader, Class<?>> entityPathType = cacheOf(QTypeContributor::getEntityPathType); | ||
|
|
||
| public static void contributeEntityPath(Class<?> type, GenerationContext context, @Nullable ClassLoader classLoader) { |
There was a problem hiding this comment.
How about making the entire code conditional based on the presence of com.querydsl.core.types.EntityPath?
There was a problem hiding this comment.
that's what happens here, just taking the ClassLoader into account.
|
|
||
| TypeContributor.contribute(repositoryInformation.getDomainType(), contribution); | ||
| QTypeContributor.contributeEntityPath(repositoryInformation.getDomainType(), contribution, |
There was a problem hiding this comment.
We should check for QTypeContributor.QUERYDSL_PRESENT or similar.
| } | ||
|
|
||
| @Nullable | ||
| private static Class<?> getEntityPathType(ClassLoader classLoader) { |
There was a problem hiding this comment.
Do we have a case where we see multiple class loaders through which we cannot see Querydsl? (Other than testing).
There was a problem hiding this comment.
I think we should use the same class loader that is used for AOT processing.
| * @param domainClass | ||
| * @return | ||
| */ | ||
| private static String getQueryClassName(Class<?> domainClass) { |
There was a problem hiding this comment.
We have a similar computation in our other Querydsl utils. It would make sense to reuse those parts.
There was a problem hiding this comment.
true, but that created cycles between the packages.
mp911de
pushed a commit
that referenced
this pull request
Dec 12, 2022
This commit introduced support for registering GraalVM native reflection type hints for Querydsl Q types that target domain types used in the repository interface declaration. At this point we only do a simple lookup for Q types based in the very same package that implement EntityPath. More advanced configuration (eg. base package and type prefix), potentially available via EntityPathResolver are not taken into account as this would require eager bean resolution from the application context, which is likely to trigger additional infrastructure. In this case the user is required to register Q types manually. Closes: #2721 Original pull request: #2743.
mp911de
pushed a commit
that referenced
this pull request
Dec 12, 2022
This commit introduced support for registering GraalVM native reflection type hints for Querydsl Q types that target domain types used in the repository interface declaration. At this point we only do a simple lookup for Q types based in the very same package that implement EntityPath. More advanced configuration (eg. base package and type prefix), potentially available via EntityPathResolver are not taken into account as this would require eager bean resolution from the application context, which is likely to trigger additional infrastructure. In this case the user is required to register Q types manually. Closes: #2721 Original pull request: #2743.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced support for registering GraalVM native reflection type hints for Querydsl
Qtypes that target domain types used in the repository interface declaration.At this point we only do a simple lookup for
Qtypes based in the very same package that implementEntityPath.More advanced configuration (eg. base package and type prefix), potentially available via
EntityPathResolverare not taken into account as this would require eager bean resolution from the application context, which is likely to trigger additional infrastructure. In this case the user is required to registerQtypes manually.Closes: #2721