Skip to content

Unfinished sentence in Object Mapping section of documentation #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sad-pancake opened this issue Dec 8, 2022 · 1 comment
Closed

Unfinished sentence in Object Mapping section of documentation #2749

sad-pancake opened this issue Dec 8, 2022 · 1 comment

Comments

@sad-pancake
Copy link

The Example 2 in Property Population has the following sentence:

  1. The remarks properties are mutable and populated by setting the comment field directly or by invoking the setter method for

as explanation of the following code:

void setRemarks(String remarks) {                                         <5>
  this.remarks = remarks;
}

The sentence appears to be incomplete. It also seems to incorrectly specify comment instead of remarks as a way to populate property. I'm not sure how that sentence should go but currently it seems weird.

Hope this is the right place to post it sorry if not.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 8, 2022
@mp911de mp911de added in: documentation and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 9, 2022
@mp911de mp911de added this to the 2.7.7 (2021.2.7) milestone Dec 9, 2022
@mp911de mp911de changed the title Unfinished sentence in Object Mapping section of documentation. Unfinished sentence in Object Mapping section of documentation Dec 9, 2022
mp911de added a commit that referenced this issue Dec 9, 2022
@mp911de mp911de closed this as completed in 14d76ab Dec 9, 2022
mp911de added a commit that referenced this issue Dec 9, 2022
@mp911de
Copy link
Member

mp911de commented Dec 9, 2022

Good catch, that's fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants