Make @ConditionalOnProperty @Repeatable #7368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements #2541 by providing @ConditionalOnProperties as container for @ConditionalOnProperty and making it repeatable.
spring-projects-issues
added
the
status: waiting-for-triage
I made a bad copy&paste error. The test was invalid. Build fails now, was not enough making annotation repeatable. Will fix asap.
|
So, my naive approach that the condition evaluator will take care of repeatable annotations was wrong. Implementing support for repeatable conditions should be provided in spring-context instead, but that's not for me to decide. |
|
@michael-simons I think you're right. It's a bit tricky without some core framework updates. |
|
Thanks anyway. |
philwebb
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #2541 by providing @ConditionalOnProperties as container for @ConditionalOnProperty and making it repeatable.
Feel free to use this PR however you like. It's based on the 2.0 branch.
I do understand that the ticket is still open for team discussion. I could understand if you are afraid of opening up to make all Conditional* repeatable, but I think also that it is really useful for ConditionalOnProperty, at least we have several use cases.
Thanks!