Skip to content

Improve logging in DockerApi #44412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve logging in DockerApi #44412

wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Feb 23, 2025

See gh-43460

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 23, 2025
@nosan nosan changed the title Add logging for Docker API version retrieval failures Improve logging in DockerApi Feb 23, 2025
@nosan
Copy link
Contributor Author

nosan commented Feb 23, 2025 •
edited
Loading

I initially considered using BuildLog in DockerApi, but it is not possible due to

Rule 'slices matching '(**)' should be free of cycles' was violated (1 times):
Cycle detected: Slice org.springframework.boot.buildpack.platform.build ->
Slice org.springframework.boot.buildpack.platform.docker ->
Slice org.springframework.boot.buildpack.platform.build

@nosan
Improve logging in DockerApi
2b04ff3 
This commit introduces a new constructor in `DockerApi`
that accepts `DockerLogger` as a parameter.

The `DockerLogger` is a pretty simple callback interface used to
provide DockerApi output logging.

See spring-projectsgh-43460

Signed-off-by: Dmytro Nosan <[email protected]>
@mhalbritter mhalbritter self-assigned this Feb 25, 2025
@mhalbritter mhalbritter mentioned this pull request Feb 25, 2025
Closed
@mhalbritter mhalbritter added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 25, 2025
@mhalbritter mhalbritter added this to the 3.5.x milestone Feb 25, 2025
mhalbritter pushed a commit that referenced this pull request Feb 25, 2025
@nosan @mhalbritter
Improve logging in DockerApi
9a94070 
This commit introduces a new constructor in `DockerApi`
that accepts `DockerLogger` as a parameter.

The `DockerLogger` is a pretty simple callback interface used to
provide DockerApi output logging.

See gh-44412

Signed-off-by: Dmytro Nosan <[email protected]>
mhalbritter added a commit that referenced this pull request Feb 25, 2025
@mhalbritter
Polish "Improve logging in DockerApi"
3be5e6c 
See gh-44412
@mhalbritter mhalbritter modified the milestones: 3.5.x, 3.5.0-M3 Feb 25, 2025
@mhalbritter
Copy link
Contributor

Thanks @nosan !

@nosan
Copy link
Contributor Author

nosan commented Feb 25, 2025

Thanks @mhalbritter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5.0-M3
Development

Successfully merging this pull request may close these issues.
3 participants
@nosan @mhalbritter @spring-projects-issues