Don't use ArgFile when using JavaCompiler #44340
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See spring-projectsgh-44305 Signed-off-by: Dmytro Nosan <[email protected]>
|
My apologies, @snicoll. |
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks @nosan, I was trying to look at this but it's taken me all day to get a Windows box installed! |
philwebb
added
type: task
|
I've installed VMware Fusion. Works perfectly :) |
philwebb
pushed a commit
that referenced
this pull request
Feb 18, 2025
See gh-44340 Signed-off-by: Dmytro Nosan <[email protected]>
|
There's no need for an apology @nosan. That's part of the review process and it's always tricky with limited access to a windows box. I like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build on Windows
see #44305
ArgFile should not be used when compiling sources via
JavaCompiler.This happens only when running a process via
ProcessBuilderbut notJavaCompiler.