qml: fix storing override amount too soon, while user is allowed to set a new override amount which was silently ignored. #9792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et a new override amount which was silently ignored. lightning: implicit save of lightning invoice with override amount deferred until actual payment is accepted. on-chain: for now, invoice is implicitly saved when override amount is passed to ConfirmTxDialog. (this is sooner than current desktop client, which saves - and only saves - when Pay is clicked from ConfirmTxDialog)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfirmTxDialog. (this is sooner than current desktop client, which saves whenOKis clicked fromConfirmTxDialog, orBroadcastis clicked fromPreview)