Implement Common #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pinMode - digitalWrite - digitalRead
the implementation is a stand-in until mbed support PwmOut and/or AnalogOut. Also possible to wrap these implementations in preprocessor statements that would allow override by a different module (external to this repo) when the necessary modules are not present in the mbed device
need to change submodule location so I am storing changes in the cloud
Common.h contains a lot of different Arduino API declarations - this splits their implementations into several files for clarity the files begin with 'Common' to indicate their relation to the Common.h interface and are postfixed with a descriptive word to indicate their particular purpose
mbed extensions to the normal Arduino API are located in 'core-extend'
the declaration mistakenly used pin_size_t as the paramter type causing an undefined reference at link
also restructured a little bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support these aspects of Arduino (from ArduinoCore-API/api/Common.h)