add generating data to integration tests #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmho
reviewed
May 9, 2025
src/integrationTest/java/com/splunk/ibm/mq/integration/tests/JakartaPutGet.java
Show resolved
Hide resolved
src/integrationTest/java/com/splunk/ibm/mq/integration/tests/JakartaPutGet.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/com/splunk/ibm/mq/integration/tests/JakartaPutGet.java
Outdated
Show resolved
Hide resolved
| * @param numberOfMessages Number of messages to send | ||
| * @param sleepIntervalMs Sleep interval in ms | ||
| */ | ||
| public static void runPutGet( |
There was a problem hiding this comment.
so this sends whole bunch of staff to the queue?
how does it help with the integration tests?
There was a problem hiding this comment.
we need active channels to collect metrics on them ; as of now, no active channels == no metrics.
There was a problem hiding this comment.
ok, i see. so this produce data for the channel so that the integration test can have metrics to collect.
mcmho
approved these changes
May 10, 2025
| * @param numberOfMessages Number of messages to send | ||
| * @param sleepIntervalMs Sleep interval in ms | ||
| */ | ||
| public static void runPutGet( |
There was a problem hiding this comment.
ok, i see. so this produce data for the channel so that the integration test can have metrics to collect.
| @@ -49,27 +50,6 @@ jobs: | |||
| done | |||
| docker exec ibm-mq-test dspmq | |||
|
|
|||
| - name: Create test queues and channel | |||
There was a problem hiding this comment.
so, now that we have data in the channel. i guess these are not needed then.
actually, they might not be needed to begin with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.