Updated Eslint Packages and Fixed All Lint Errors #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reconstructions AWESOME! Reviewed 10 of 10 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the Eslint packages to the latest versions in client/package.json, changed the rake lint:eslint task to run
npm run lint, and minimally refactored the JS code to get rid of lint errors.Most of the fixes were straightforward absolute/relative import reordering or single/double quote substitutions. I used two
eslint-disablestatements where I wasn't sure which way you would want to go with the fixes:eslint-disable no-script-url
eslint-disable react/prefer-stateless-function
Thanks in advance for reviewing!
This change is