Skip to content

Record whether viewport percentage dimensions are seen #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2016

Conversation

mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Mar 4, 2016

Used to tell Servo to recalulate styles on window resize (servo/servo#8754).

r? @SimonSapin

Review on Reviewable

@SimonSapin
Copy link
Member

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


src/tokenizer.rs, line 226 [r1] (raw file):
Nit: maybe rename the VarFunction enum and use it for both? I don’t have a good name to suggest though :/


src/tokenizer.rs, line 810 [r1] (raw file):
This needs to be an ASCII case-insensitive match. Unfortunately match_ignore_ascii_case! doesn’t support alternates with | and can’t easily since x | y is a valid expression. Maybe use name.eq_ignore_ascii_case(…) directly?


Comments from the review on Reviewable.io

Used to tell Servo to recalulate styles on window resize (servo/servo#8754).
@mbrubeck mbrubeck force-pushed the seen-viewport-percentages branch from d9dd56b to 49d1d30 Compare March 18, 2016 23:29
@mbrubeck
Copy link
Contributor Author

Review status: 1 of 3 files reviewed at latest revision, 2 unresolved discussions.


src/tokenizer.rs, line 226 [r1] (raw file):
Done.


src/tokenizer.rs, line 810 [r1] (raw file):
Done.


Comments from the review on Reviewable.io

@SimonSapin
Copy link
Member

@bors-servo r+


Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@SimonSapin
Copy link
Member

I’ve hit "Synchronize" in http://build.servo.org/homu/queue/rust-cssparser

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 81523c4 has been approved by SimonSapin

bors-servo pushed a commit that referenced this pull request Mar 19, 2016
Record whether viewport percentage dimensions are seen

Used to tell Servo to recalulate styles on window resize (servo/servo#8754).

r? @SimonSapin

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/99)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 81523c4 with merge 4ab1d41...

@bors-servo
Copy link
Contributor

☀️ Test successful - travis

@bors-servo bors-servo merged commit 81523c4 into servo:master Mar 19, 2016
@SimonSapin
Copy link
Member

Published v0.5.5 on crates.io

bors-servo pushed a commit to servo/servo that referenced this pull request Mar 19, 2016
Recompute styles on viewport size change if they contain viewport percentages

Fixes #8754.  Depends on servo/rust-cssparser#99.  r? @SimonSapin

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9876)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Mar 19, 2016
Recompute styles on viewport size change if they contain viewport percentages

Fixes #8754.  Depends on servo/rust-cssparser#99.  r? @SimonSapin

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9876)
<!-- Reviewable:end -->
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
… contain viewport percentages (from mbrubeck:seen-viewport-percentages); r=SimonSapin

Fixes #8754.  Depends on servo/rust-cssparser#99.  r? SimonSapin

Source-Repo: https://github.com/servo/servo
Source-Revision: a4251c832d605a02d6c82fc188d1746367599e59

UltraBlame original commit: ad73447080ab4eab6404b52b1c00370d8f7c332f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
… contain viewport percentages (from mbrubeck:seen-viewport-percentages); r=SimonSapin

Fixes #8754.  Depends on servo/rust-cssparser#99.  r? SimonSapin

Source-Repo: https://github.com/servo/servo
Source-Revision: a4251c832d605a02d6c82fc188d1746367599e59

UltraBlame original commit: ad73447080ab4eab6404b52b1c00370d8f7c332f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
… contain viewport percentages (from mbrubeck:seen-viewport-percentages); r=SimonSapin

Fixes #8754.  Depends on servo/rust-cssparser#99.  r? SimonSapin

Source-Repo: https://github.com/servo/servo
Source-Revision: a4251c832d605a02d6c82fc188d1746367599e59

UltraBlame original commit: ad73447080ab4eab6404b52b1c00370d8f7c332f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants