-
Notifications
You must be signed in to change notification settings - Fork 136
Record whether viewport percentage dimensions are seen #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewed 2 of 2 files at r1. src/tokenizer.rs, line 226 [r1] (raw file): src/tokenizer.rs, line 810 [r1] (raw file): Comments from the review on Reviewable.io |
Used to tell Servo to recalulate styles on window resize (servo/servo#8754).
d9dd56b
to
49d1d30
Compare
Review status: 1 of 3 files reviewed at latest revision, 2 unresolved discussions. src/tokenizer.rs, line 226 [r1] (raw file): src/tokenizer.rs, line 810 [r1] (raw file): Comments from the review on Reviewable.io |
@bors-servo r+ Reviewed 2 of 2 files at r2. Comments from the review on Reviewable.io |
I’ve hit "Synchronize" in http://build.servo.org/homu/queue/rust-cssparser @bors-servo r+ |
📌 Commit 81523c4 has been approved by |
Record whether viewport percentage dimensions are seen Used to tell Servo to recalulate styles on window resize (servo/servo#8754). r? @SimonSapin <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/99) <!-- Reviewable:end -->
☀️ Test successful - travis |
Published v0.5.5 on crates.io |
Recompute styles on viewport size change if they contain viewport percentages Fixes #8754. Depends on servo/rust-cssparser#99. r? @SimonSapin <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9876) <!-- Reviewable:end -->
Recompute styles on viewport size change if they contain viewport percentages Fixes #8754. Depends on servo/rust-cssparser#99. r? @SimonSapin <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9876) <!-- Reviewable:end -->
… contain viewport percentages (from mbrubeck:seen-viewport-percentages); r=SimonSapin Fixes #8754. Depends on servo/rust-cssparser#99. r? SimonSapin Source-Repo: https://github.com/servo/servo Source-Revision: a4251c832d605a02d6c82fc188d1746367599e59 UltraBlame original commit: ad73447080ab4eab6404b52b1c00370d8f7c332f
… contain viewport percentages (from mbrubeck:seen-viewport-percentages); r=SimonSapin Fixes #8754. Depends on servo/rust-cssparser#99. r? SimonSapin Source-Repo: https://github.com/servo/servo Source-Revision: a4251c832d605a02d6c82fc188d1746367599e59 UltraBlame original commit: ad73447080ab4eab6404b52b1c00370d8f7c332f
… contain viewport percentages (from mbrubeck:seen-viewport-percentages); r=SimonSapin Fixes #8754. Depends on servo/rust-cssparser#99. r? SimonSapin Source-Repo: https://github.com/servo/servo Source-Revision: a4251c832d605a02d6c82fc188d1746367599e59 UltraBlame original commit: ad73447080ab4eab6404b52b1c00370d8f7c332f
Used to tell Servo to recalulate styles on window resize (servo/servo#8754).
r? @SimonSapin