Don't heap-allocate a tokenizer for top-level parsing. #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC when I wrote this I did not expect creating new parsers to be hot. Is it for CSSOM setters? |
|
Ah you already replied yes on IRC :) @bors-servo r+ |
|
📌 Commit 13662ef has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 3, 2017
Don't heap-allocate a tokenizer for top-level parsing. r? @SimonSapin <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/124) <!-- Reviewable:end -->
|
@bors-servo r- I'll update the MaybeOwned docs. |
This matters when parsing single property declarations, see bug 1344131[1]. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1344131
|
(MaybeOwned is not public, but yeah) @bors-servo r+ |
|
📌 Commit 16dfdeb has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 3, 2017
Don't heap-allocate a tokenizer for top-level parsing. r? @SimonSapin <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/124) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
emilio
added a commit
to emilio/servo
that referenced
this pull request
Mar 6, 2017
In particular, it it includes servo/rust-cssparser#124
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Mar 6, 2017
Update cssparser to get perf improvements for CSSOM setters. In particular, it it includes servo/rust-cssparser#124 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15830) <!-- Reviewable:end -->
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 7, 2017
…SSOM setters (from emilio:cssparserup); r=KiChjang In particular, it it includes servo/rust-cssparser#124 Source-Repo: https://github.com/servo/servo Source-Revision: c62973b77b6ac74c0daf11b1f4c18b9dd64ae400 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 42809d20c09bd2bbf5eaac50ab7ddbfcef01a49c
Manishearth
pushed a commit
to Manishearth/gecko-dev
that referenced
this pull request
Mar 13, 2017
…SSOM setters (from emilio:cssparserup); r=KiChjang In particular, it it includes servo/rust-cssparser#124 Source-Repo: https://github.com/servo/servo Source-Revision: c62973b77b6ac74c0daf11b1f4c18b9dd64ae400
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Mar 13, 2017
…SSOM setters (from emilio:cssparserup); r=KiChjang In particular, it it includes servo/rust-cssparser#124 Source-Repo: https://github.com/servo/servo Source-Revision: c62973b77b6ac74c0daf11b1f4c18b9dd64ae400
clementmiao
pushed a commit
to clementmiao/servo
that referenced
this pull request
Apr 7, 2017
In particular, it it includes servo/rust-cssparser#124
Closed
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…SSOM setters (from emilio:cssparserup); r=KiChjang In particular, it it includes servo/rust-cssparser#124 Source-Repo: https://github.com/servo/servo Source-Revision: c62973b77b6ac74c0daf11b1f4c18b9dd64ae400 UltraBlame original commit: deafdcdf32a52d0dfb81af6c34110fd894764d8f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…SSOM setters (from emilio:cssparserup); r=KiChjang In particular, it it includes servo/rust-cssparser#124 Source-Repo: https://github.com/servo/servo Source-Revision: c62973b77b6ac74c0daf11b1f4c18b9dd64ae400 UltraBlame original commit: deafdcdf32a52d0dfb81af6c34110fd894764d8f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…SSOM setters (from emilio:cssparserup); r=KiChjang In particular, it it includes servo/rust-cssparser#124 Source-Repo: https://github.com/servo/servo Source-Revision: c62973b77b6ac74c0daf11b1f4c18b9dd64ae400 UltraBlame original commit: deafdcdf32a52d0dfb81af6c34110fd894764d8f
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…SSOM setters (from emilio:cssparserup); r=KiChjang In particular, it it includes servo/rust-cssparser#124 Source-Repo: https://github.com/servo/servo Source-Revision: c62973b77b6ac74c0daf11b1f4c18b9dd64ae400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @SimonSapin
This change is