Skip to content

Enhance poetry related logging and add new flag #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

FinchPowers
Copy link
Contributor

  • Distinct logging whether the requirements.txt file is generated from
    poetry.lock vs pyproject.toml.
  • New boolean flag: requirePoetryLockFile - When set to true, fail the build
    when poetry.lock is missing. This helps with creating reproducible
    builds where you want to have a fixed poetry.lock file instead of one
    generated on the fly.

Note that there are no tests. With some guidance I am willing to add some.

* Distinct logging whether the requirements.txt file is generated from
  poetry.lock vs pyproject.toml.
* New boolean flag: requirePoetryLockFile - When set to true, fail the build
  when poetry.lock is missing. This helps with creating reproducible
  builds where you want to have a fixed poetry.lock file instead of one
  generated on the fly.
@FinchPowers FinchPowers force-pushed the feature/log-and-require-poetry-lock branch from cc54d84 to f1c19f9 Compare October 28, 2021 18:38
@pgrzesik
Copy link
Contributor

Hey @FinchPowers - it's been a long time since this PR was proposed. I'm going to close it, if you feel like the issue is valid, please open a new issue or a new PR against the latest main branch. Thanks 🙇

@pgrzesik pgrzesik closed this Sep 27, 2022
@FinchPowers
Copy link
Contributor Author

It's still valid, but I won't fight for it if you don't want the feature merged in.
👍

@pgrzesik
Copy link
Contributor

Hey @FinchPowers - it's not about not wanting the feature to be merged in - the PR was quite outdated and conflicting against the current main. I'm trying to dedicate some of my free time to the maintenance of this repository and I was just trying to clean up potentially stale PRs. Could you please try to rebase against the current main and reopen the PR? Thanks in advance 🙇

@FinchPowers
Copy link
Contributor Author

Oh I apologize. I did not realize there were some conflicts now. I'll try to get to it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants