Skip to content

Aggregate raw coverage data, not XML reports #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

gslowikowski
Copy link
Member

@gslowikowski gslowikowski commented Nov 12, 2018

When generating aggregated reports in multi-module builds, coverage data were read from per-module XML reports - scoverage.xml files.

These reports contain the same data as internal raw data files: scoverage.coverage and scoverage.measurements.*.

Coverage data for aggregated reports will be read from raw data files. This has some advantages:

  • generating per-module reports (coverageReport) is not required prior to generating aggregated report (coverageAggregate); this is the most important advantage,
  • reading coverage data from plain text files is usually (from my experience - always) faster than parsing XML files
  • fixes small bug in aggregated scoverage-debug.xml report, generated when coverageOutputDebug is set to true (statement element's value as well as symbol and tree attributes were not filled)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant