Skip to content

Do not fail on missing scoverage compile task in dependency #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JozoVilcek
Copy link
Contributor

Fix for #136

@eyalroth
Copy link
Contributor

Looks good, thank you for the contribution!

Could you add a new functional test which replicates the bug? Take a look at the functionalTest directory for reference. Also, I believe that this particular test case only needs a "dry run", since it tests the configuration and not the actual execution of the plugin.

@JozoVilcek
Copy link
Contributor Author

@eyalroth I can try. Do you prefer to edit one of existing projects (which one?) or create a new one specifically for this purpose?

@eyalroth
Copy link
Contributor

I think a new project is preferable; otherwise, this will make the other existing projects more complex than they should be.

@JozoVilcek JozoVilcek force-pushed the fix-missing-dependency-compile-task branch from 2e52377 to e7fc279 Compare April 19, 2020 20:45
@JozoVilcek
Copy link
Contributor Author

@eyalroth can you take a loot at change and suggest further changes to the tests if needed? Thanks

@eyalroth
Copy link
Contributor

eyalroth commented Apr 21, 2020

@JozoVilcek Oh I wasn't notified on your force-push. The test looks good, as long as it fails without the fix :)

FYI I don't have write permissions so I can't merge this. @maiflai

@JozoVilcek
Copy link
Contributor Author

@maiflai do you have time to look at this PR?

@maiflai maiflai merged commit cbe754d into scoverage:master May 9, 2020
@JozoVilcek JozoVilcek deleted the fix-missing-dependency-compile-task branch May 10, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants