Skip to content

MNT update test framework for sklearn 0.24 #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Feb 8, 2021

Conversation

glemaitre
Copy link
Member

Update test framework to be compatible with scikit-learn 0.24

@pep8speaks
Copy link

pep8speaks commented Feb 3, 2021

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 23:1: E402 module level import not at top of file
Line 24:1: E402 module level import not at top of file
Line 24:1: F401 'sphinx_gallery' imported but unused
Line 88:1: E402 module level import not at top of file

Comment last updated at 2021-02-08 19:35:08 UTC

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #788 (3f9f10d) into master (2a0376e) will increase coverage by 1.98%.
The diff coverage is 99.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
+ Coverage   96.55%   98.53%   +1.98%     
==========================================
  Files          82       89       +7     
  Lines        5140     5683     +543     
  Branches        0      476     +476     
==========================================
+ Hits         4963     5600     +637     
+ Misses        177       82      -95     
- Partials        0        1       +1     
Impacted Files Coverage Δ
imblearn/combine/_smote_enn.py 100.00% <ø> (ø)
imblearn/combine/_smote_tomek.py 100.00% <ø> (ø)
imblearn/datasets/_imbalance.py 88.23% <ø> (ø)
imblearn/datasets/_zenodo.py 96.77% <ø> (ø)
imblearn/ensemble/_bagging.py 97.82% <ø> (ø)
imblearn/ensemble/_easy_ensemble.py 100.00% <ø> (ø)
imblearn/ensemble/_forest.py 97.36% <ø> (ø)
imblearn/ensemble/_weight_boosting.py 97.75% <ø> (ø)
imblearn/keras/_generator.py 97.14% <ø> (+44.28%) ⬆️
imblearn/over_sampling/_adasyn.py 98.41% <ø> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd7522...bff2e51. Read the comment docs.

@glemaitre glemaitre merged commit dc4051f into scikit-learn-contrib:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants