fix #9873: move scala.Enum to scala.reflect.Enum #9942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
approved these changes
Oct 5, 2020
bishabosha
force-pushed
the
topic/enum-rename-scala-enum
branch
from
54f9ef5 to
5b9b296
Compare
bishabosha
commented
Oct 5, 2020
| package scala.reflect | ||
|
|
||
| /** A base trait of all enum classes */ | ||
| super trait Enum extends Any, Product, Serializable: |
There was a problem hiding this comment.
added Any super class so it will be eliminated by drop super traits when the common superclass is AnyRef
bishabosha
force-pushed
the
topic/enum-rename-scala-enum
branch
from
5b9b296 to
f7797dd
Compare
scala.reflect.Enum is now a universal super trait. Also avoid using derivesFrom(defn.EnumClass) and instead look for enum flag.
bishabosha
force-pushed
the
topic/enum-rename-scala-enum
branch
from
f7797dd to
8f21d24
Compare
smarter
approved these changes
Oct 5, 2020
bishabosha
force-pushed
the
topic/enum-rename-scala-enum
branch
from
cc453ce to
c76c4ee
Compare
odersky
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #9877
scala.reflect.Enum is now a universal super trait.
Also avoid using
derivesFrom(defn.EnumClass)and instead look for enum flag.